peerstore: limit number of non connected peers in addrbook #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
reviewed
Oct 16, 2024
core/peerstore/peerstore.go
Outdated
| @@ -133,13 +138,17 @@ type AddrBook interface { | |||
| // cab.ConsumePeerRecord(signedPeerRecord, aTTL) | |||
| // } | |||
| type CertifiedAddrBook interface { | |||
| // A CertifiedAddrBook is an address book. To remove peers, use the available | |||
| // methods on the AddrBook. | |||
| AddrBook | |||
There was a problem hiding this comment.
There's no way to remove a certified peer record from the CertifiedAddrBook. You cannot use the CertifiedAddrBook without an AddrBook, so I made it an AddrBook.
| heapIndex int | ||
| } | ||
|
|
||
| func (e *expiringAddr) ExpiredBy(t time.Time) bool { | ||
| return !t.Before(e.Expiry) | ||
| } | ||
|
|
||
| var expiringAddrPool = sync.Pool{New: func() any { return &expiringAddr{} }} |
There was a problem hiding this comment.
Can you expand a bit what prompted the change to add a pool? And did you see a perf difference in the benchmark?
There was a problem hiding this comment.
I didn't have a benchmark. I'll add one.
MarcoPolo
force-pushed
the
sukun/peerstore-limit
branch
from
5f91eda
to
9bed4bc
Compare
MarcoPolo
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.