fix: enable dctur when interface address is public

[2color]

What's in this PR

This change attempts to fix #2913.

In essence, it enables the dctur protocol, when a peer has a public IP (if it's bound to an interface with a public IP) without having to wait for an identify response (which would then make the public address visible via OwnObservedAddrs()).

Open questions

• The OwnObservedAddrs() function in the identify service (which we rely on in the holepunch service) seems to not return observed addresses if they aren't dialable. Why is that?
  • Should be fixed by fix: QUIC/Webtransport Transports now will prefer their owned listeners for dialing out #2936

[sukunrt]

Thanks @2color

[MarcoPolo]

I have some questions about the issue. Let's continue the discussion there. But one quick thing:

The OwnObservedAddrs() function in the identify service (which we rely on in the holepunch service) seems to not return observed addresses if they aren't dialable. Why is that?

What do you mean by dialable? By not dialable do you mean that the host will drop unsolicited incoming packets?

[2color]

By not dialable do you mean that the host will drop unsolicited incoming packets?

Exactly. It binds to a port on an interface with a public IP, however the firewall blocks incoming connections on that port.

[2color]

I've addressed your feedback @sukunrt.

[sukunrt]

@MarcoPolo The change looks reasonable to me. If the node does have access to its own public address there's no reason to depend on identify for address discovery for hole punching.

[MarcoPolo]

This change makes sense. After addressing @sukunrt's comment this should be good to merge

stale