update go-multiaddr to v0.11.0 #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
update-multiaddr
branch
from
221ef01
to
16084b0
Compare
marten-seemann
commented
Aug 9, 2023
Comment on lines
-217
to
+221
| slices.SortFunc(s, func(first, second *observedAddr) bool { | ||
| if first.numInbound > second.numInbound { | ||
| return true | ||
| slices.SortFunc(s, func(first, second *observedAddr) int { | ||
| if first.numInbound > second.numInbound || len(first.seenBy) > len(second.seenBy) { | ||
| return -1 | ||
| } | ||
| return len(first.seenBy) > len(second.seenBy) | ||
| return 1 |
There was a problem hiding this comment.
Please check the logic carefully.
MarcoPolo
reviewed
Aug 10, 2023
| if first.numInbound > second.numInbound { | ||
| return true | ||
| slices.SortFunc(s, func(first, second *observedAddr) int { | ||
| if first.numInbound > second.numInbound || len(first.seenBy) > len(second.seenBy) { |
There was a problem hiding this comment.
Old behavior is still here, and the new behavior seems reasonable. Should we update the comment?
There was a problem hiding this comment.
Old behavior is still here, and the new behavior seems reasonable.
What do you mean? I didn't mean to change the behavior. Did I mess up the logic?
MarcoPolo
approved these changes
Aug 10, 2023
7 tasks
sukunrt
approved these changes
Aug 14, 2023
Comment on lines
-217
to
+221
| slices.SortFunc(s, func(first, second *observedAddr) bool { | ||
| if first.numInbound > second.numInbound { | ||
| return true | ||
| slices.SortFunc(s, func(first, second *observedAddr) int { | ||
| if first.numInbound > second.numInbound || len(first.seenBy) > len(second.seenBy) { | ||
| return -1 | ||
| } | ||
| return len(first.seenBy) > len(second.seenBy) | ||
| return 1 |
|
Will this change be included in |
|
That’s not possible according to semver rules. |
|
Then I'll guess we have to wait for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is getting in two important changes in go-multiaddr that many users have been complaining about (see release notes).