swarm: remove unnecessary reqno for pending request tracking #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if !ok { | ||
| // some other dial for this request succeeded before this one | ||
| continue | ||
| for pr := range w.pendingRequests { |
There was a problem hiding this comment.
This loop will now be executed in random order. Is that ok?
There was a problem hiding this comment.
| continue | ||
| } | ||
|
|
||
| for pr := range w.pendingRequests { |
There was a problem hiding this comment.
Yeah. Assuming we have two go routines waiting.
- We don't actually guarantee ordered delivery. This just publishes to a channel. This channel is being read here. So the waiting go routines may be run in a different order.
- This doesn't block. The channel has 1 capacity, so both the waiters are notified immediately.
I don't know of any case where this might be an issue especially considering 1.
Also here we do provide an out of order delivery. In this case the first requester will be informed of the connection after the second requester(which added a valid address) was informed.
marten-seemann
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
LGTM, this looks like a nice simplification. I don't think it resolves #2380 though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First merge this to backoff cleanup and then we can merge both to master.
Opening small PRs for individual items since this piece is complicated