Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify: filter nat64 well-known prefix ipv6 addresses #2392

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Jun 26, 2023

fixes #2349

For details see #2349 (comment)

@sukunrt sukunrt marked this pull request as draft June 26, 2023 17:43
@sukunrt sukunrt force-pushed the sukun/identify-filter-nat64-ipv6-addresses branch from 620071e to 93c9b2a Compare June 26, 2023 18:33
@sukunrt sukunrt marked this pull request as ready for review June 26, 2023 18:35
p2p/protocol/identify/obsaddr.go Outdated Show resolved Hide resolved
p2p/protocol/identify/obsaddr.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAT64 adresses shouldn't be advertised, this makes sense to me.

@sukunrt
Copy link
Member Author

sukunrt commented Jul 10, 2023

blocked on multiformats/go-multiaddr#205

@sukunrt sukunrt mentioned this pull request Jul 10, 2023
29 tasks
@sukunrt sukunrt force-pushed the sukun/identify-filter-nat64-ipv6-addresses branch from 93c9b2a to d4284b9 Compare July 10, 2023 20:23
@sukunrt
Copy link
Member Author

sukunrt commented Jul 10, 2023

updated.

@sukunrt sukunrt merged commit 87f3eea into master Jul 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle dial prioritisation for well known prefix IPv4 embedded IPv6 addresses
3 participants