Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: return filtered addrs in addrsForDial #1855

Merged
merged 1 commit into from
Nov 8, 2022
Merged

swarm: return filtered addrs in addrsForDial #1855

merged 1 commit into from
Nov 8, 2022

Conversation

dennis-tra
Copy link
Contributor

@dennis-tra dennis-tra commented Nov 4, 2022 •
edited
Loading

Commit f654b4b introduced multiaddress resultion by transport and changed the return value from goodAddrs to resolved. I guess this should be goodAddrs again?

cc @MarcoPolo

@dennis-tra dennis-tra changed the title fix: return filtered addrs fix: return filtered addrs in addrsForDial Nov 4, 2022
marten-seemann
marten-seemann approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll let @MarcoPolo do another review, as this was introduced in #1719.

@marten-seemann marten-seemann changed the title fix: return filtered addrs in addrsForDial swarm: return filtered addrs in addrsForDial Nov 5, 2022
@marten-seemann
Copy link
Contributor

We should probably also have a test, stuff like this should have been caught be a unit test.

@p-shahi
Copy link
Member

p-shahi commented Nov 8, 2022

I think this could be a candidate to include in 0.23.4 along with connection manager map fix
Wdyt @MarcoPolo @julian88110 @marten-seemann?

MarcoPolo
MarcoPolo approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any reason why I would prefer resolved. Looks like my bug. Thanks for the catch! 🐛 🥾

@MarcoPolo MarcoPolo merged commit 2d28a04 into libp2p:master Nov 8, 2022
MarcoPolo pushed a commit that referenced this pull request Nov 8, 2022
@dennis-tra @MarcoPolo
fix: return filtered addrs (#1855)
e25c784
MarcoPolo pushed a commit that referenced this pull request Nov 9, 2022
@dennis-tra @MarcoPolo
fix: return filtered addrs (#1855)
a1a4723
MarcoPolo added a commit that referenced this pull request Nov 9, 2022
@MarcoPolo @dennis-tra
Release v0.23.4 (#1864)
9ade760 
* fix: return filtered addrs (#1855)

* Bump version

* Fix concurrent map access in connmgr (#1860)

* Add some guard rails and docs (#1863)

Co-authored-by: Dennis Trautwein <git@dtrautwein.eu>
@lidel lidel mentioned this pull request Nov 9, 2022
Closed
3 tasks
@p-shahi p-shahi mentioned this pull request Dec 5, 2022
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dennis-tra @marten-seemann @p-shahi @MarcoPolo