Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcmgr: increase default connection memory limit to 32 MB #1740

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

marten-seemann
Copy link
Contributor

Fixes #1706.

@marten-seemann marten-seemann marked this pull request as ready for review September 5, 2022 10:33
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16 is probably enough, but shouldnt be a problem.
You might also want to adjust the peer base limit to 16M at least.

@marten-seemann
Copy link
Contributor Author

marten-seemann commented Sep 6, 2022

16 is probably enough, but shouldnt be a problem.

The maximum flow control window that quic-go uses is 15 MB, and we're reserving with 128 priority, so we'll need to set this to 30 MB at least. Will update the PR to use 32 MB.

@marten-seemann
Copy link
Contributor Author

You might also want to adjust the peer base limit to 16M at least.

It's already at 64:

PeerBaseLimit: BaseLimit{
ConnsInbound: 4,
ConnsOutbound: 8,
Conns: 8,
StreamsInbound: 256,
StreamsOutbound: 512,
Streams: 512,
Memory: 64 << 20,
FD: 4,
},

@marten-seemann marten-seemann changed the title rcmgr: increase default connection memory limit to 64 MB rcmgr: increase default connection memory limit to 32 MB Sep 6, 2022
@marten-seemann marten-seemann merged commit b810812 into master Sep 6, 2022
@marten-seemann marten-seemann deleted the increase-conn-limit branch November 8, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rcmgr: connection-level memory base limits are too small for performant QUIC transfers
2 participants