autorelay: Add a context.Context to WithPeerSource callback #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,7 +59,7 @@ type relayFinder struct { | |||
| ctxCancel context.CancelFunc | |||
| ctxCancelMx sync.Mutex | |||
|
|
|||
| peerSource func(int) <-chan peer.AddrInfo | |||
| peerSource func(context.Context, int) <-chan peer.AddrInfo | |||
There was a problem hiding this comment.
Would it make sense to remove the int here, and have the caller give us new nodes until we cancel the context?
There was a problem hiding this comment.
Maybe ?
The int allows to create a buffered channel of the right size for synchronous or partially synchronous implementations tho.
marten-seemann
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of this is to stop the search when the libp2p stops.
I've added that this might be used in the future to notify when AutoRelay is satisfied just to not close any door in the future but havn't implemented anything like that.