-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add cross-version interop #1725
ci: add cross-version interop #1725
Conversation
@marten-seemann interop test - take two :) |
custom_git_target: github.com/${{ github.event.pull_request.head.repo.full_name || github.event.repository.full_name }} | ||
custom_git_reference: ${{ github.event.pull_request.head.sha || github.sha }} | ||
run-ping-interop-cross-implementation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the test that takes 70 minutes that you talked about yesterday?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No no, there is no test that takes 70 minutes,
This test takes ~17 minutes. It test go-libp2p master + rust-libp2p master + the current branch.
There is a larger test that takes around ~27 minutes that tests all known versions together + the current branch but we won't enable it yet.
See the results here:
libp2p/test-plans#32 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I shared 2 examples pull requests in the description if you want to see a recent run using this code:
passing: https://github.com/laurentsenta/go-libp2p/actions/runs/2955179619
breaking: https://github.com/laurentsenta/go-libp2p/actions/runs/2955183270
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but please wait for @marten-seemann 's approval 🤝
Description
Update workflows on push & PR:
run-ping-interop-cross-version
: runs a Testground interoperability test between multiple versions of go-libp2p, including master, and the current branch (during a pull request)run-ping-interop-cross-implementation
: runs a Testground interoperability test between go-libp2p and rust-libp2p, including master, and the current branch (during a pull request)We rely on the https://github.com/libp2p/test-plans/ repository to retrieve and run the tests.
Demonstration: