connmgr: prefer peers with no streams when closing connections #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
approved these changes
Aug 13, 2022
There was a problem hiding this comment.
This change looks good to me.
At some point in the future, we probably should make this act on connections, not on peers. For example, if we have more than a single connection to a peer, we should prune the duplicate connections first (interesting question: how would we decide if to prune a TCP connection with more streams vs a QUIC connection with fewer streams).
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prioritized closing connections with peers that have no active streams. This enables us to prune inactive connections rather than a potentially active but lower value connection.
Removes
SortByValueand changesSortByValueAndStreamsto work for both the normal case and the emergency memory free up mode.