Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basichost: Fix flakey test on windows by scaling up timeout #1572

Closed

Conversation

MarcoPolo
Copy link
Collaborator

TestSignedPeerRecordWithNoListenAddrs Has flaked at least 10 times on Windows in the last week: https://observablehq.com/@realmarcopolo/top-flaky-tests-on-go-libp2p

This simply scales up the timeout times on CI.

@marten-seemann
Copy link
Contributor

Any reason not to just use a longer timeout here, as we've done for the other tests? (I think I've submitted a fix along those lines in #1559)

@MarcoPolo
Copy link
Collaborator Author

MarcoPolo commented May 27, 2022

No strong thoughts here.

My reasoning is to convey that CI may run 10x slower than your laptop. When writing tests locally it's fine to use numbers that make sense for you, then wrap those numbers with this function. It's a better flow I think to pick reasonable numbers that work for you locally and then wrap this scale duration function, than it is to scale numbers directly.

It's also a signal of: "We've bumped these numbers already, maybe we should try something else if this test keeps being flakey"

@MarcoPolo
Copy link
Collaborator Author

Closing as already fixed

@MarcoPolo MarcoPolo closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants