move go-stream-muxer-multistream here #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import the correct go-stream-muxer repo
Stebalien
reviewed
May 19, 2022
| @@ -0,0 +1,75 @@ | |||
| // Package multistream implements a peerstream transport using | |||
There was a problem hiding this comment.
File name: muxer-multistream? It would be nice if this matched the security version.
Location: Maybe put this in /muxer? it's a muxer combinator, but it's also a muxer. But I don't feel strongly about that.
Package name: Not multistream (going to get a bit confusing?). But I'm not sure what to call it. Maybe multistream_muxer?
There was a problem hiding this comment.
Not a big fan, but let's go with muxer-multistream for now.
There was a problem hiding this comment.
Yeah, all these names are long and annoying. I just want to be as consistent as possible.
There was a problem hiding this comment.
Is there anything else I should change? It's muxer-multistream everywhere now.
marten-seemann
force-pushed
the
merge-muxer-multistream
branch
from
2bbe167
to
f55198b
Compare
marten-seemann
force-pushed
the
merge-muxer-multistream
branch
from
f55198b
to
6fa9153
Compare
vyzo
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1187. We didn't discuss the target directory in that issue, so please pay special attention to that when reviewing.