add remote multiaddr from active connection to peerstore #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
fix/address-observe
branch
2 times, most recently
from
3518749
to
e4934f1
Compare
|
LGTM 👍 |
whyrusleeping
added a commit
that referenced
this pull request
Feb 18, 2016
add remote multiaddr from active connection to peerstore
marten-seemann
added a commit
that referenced
this pull request
May 26, 2022
marten-seemann
added a commit
that referenced
this pull request
Aug 15, 2022
marten-seemann
pushed a commit
that referenced
this pull request
Aug 17, 2022
feat(peer): implement AddrInfosFromP2pAddrs and SplitAddr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the main change is question is on line 193, the rest is just a quick readability cleanup.
It doesnt appear that we ever add the actual address we get from the actual connection to the peerstore. That seems like a fairly severe oversight to me...