Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move go-libp2p-mplex here #1450

Merged
merged 30 commits into from
Apr 26, 2022
Merged

move go-libp2p-mplex here #1450

merged 30 commits into from
Apr 26, 2022

Conversation

marten-seemann
Copy link
Contributor

Part of #1187.

@marten-seemann marten-seemann mentioned this pull request Apr 25, 2022
65 tasks
@marten-seemann marten-seemann force-pushed the merge-mplex branch 2 times, most recently from ed6a9b5 to d6a12cb Compare April 25, 2022 13:29
@@ -15,6 +15,8 @@ import (
"testing"
"time"

mplex "github.com/libp2p/go-libp2p/p2p/muxer/mplex"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the rename?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package is named peerstream_multiplex, so I think we do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, can we, like, fix that. Now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. We should probably do the same for yamux.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants