Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make QUIC a default transport #1128

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

marten-seemann
Copy link
Contributor

This means that we'll finally be able to set the QUIC version in go-libp2p as well.

@Stebalien
Copy link
Member

  1. Let's do a patch release with the new TCP transport first (and maybe get the yamux fix in?). Then we can put this in a major release.
  2. We should probably get implement a Transport.Close that waits for the reuse's GC to finish go-libp2p-quic-transport#211 in first, if possible.

@marten-seemann
Copy link
Contributor Author

Let's do a patch release with the new TCP transport first (and maybe get the yamux fix in?). Then we can put this in a major release.

Agreed, that was the plan anyway.

We should probably get implement a Transport.Close that waits for the reuse's GC to finish go-libp2p-quic-transport#211 in first, if possible.

CI on this PR seems even more flaky than before, I hope that this PR helps.

@marten-seemann marten-seemann force-pushed the quic-default-transport branch 6 times, most recently from 4d0d3fc to 6d3b63a Compare August 21, 2021 11:19
@marten-seemann marten-seemann merged commit 659ded5 into master Sep 7, 2021
@marten-seemann marten-seemann deleted the quic-default-transport branch September 7, 2021 13:30
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants