Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow peerstore to write to a go-datastore #90

Closed
csasarak opened this issue Aug 18, 2016 · 4 comments
Closed

Allow peerstore to write to a go-datastore #90

csasarak opened this issue Aug 18, 2016 · 4 comments
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue status/deferred Conscious decision to pause or backlog

Comments

@csasarak
Copy link

I am working with @whyrusleeping to allow peerstore data to be stored to the hard disk when it takes up a certain amount of space as described in go-ipfs issue #2484

I'm opening this issue to discuss adding support for the go-datastore interface.

@jbenet
Copy link
Contributor

jbenet commented Aug 18, 2016

wonder if we should reuse the record abstraction here @diasdavid? Basically
peerstore, providers, and so on all storing records and internally they can
be given a recordstore implementation backed by a go-datastore to store to
disk. Would seriously simplify the abstraction creep in all the modules.
(I.e. Only one module would know why a datastore is a thing).

I think @diasdavid already does something like this, or has suggested it in
the past.
On Wed, Aug 17, 2016 at 20:33 Christopher Sasarak notifications@github.com
wrote:

I am working with @whyrusleeping https://github.com/whyrusleeping to
allow peerstore data to be stored to the hard disk when it takes up a
certain amount of space as described in go-ipfs issue #2484
ipfs/kubo#2848

I'm opening this issue to discuss adding support for the go-datastore
interface.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#90, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIcoSeNGrypxq91fZkrKBJ9EzCFvUGBks5qg6hlgaJpZM4JnBaw
.

@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Sep 14, 2016
@daviddias
Copy link
Member

do we need to sign the peer info objects? storing them as records would mean that, which might be a good thing and also, would write them to disk with some validity property.

@ghost ghost added status/deferred Conscious decision to pause or backlog and removed status/deferred Conscious decision to pause or backlog labels Nov 12, 2016
@Kubuxu Kubuxu added the status/deferred Conscious decision to pause or backlog label Nov 28, 2016
@daviddias daviddias added the exp/expert Having worked on the specific codebase is important label Aug 19, 2017
@bigs
Copy link
Contributor

bigs commented May 31, 2018

I'm gonna take a go at this! There already seems to be some work done on the go-libp2p-peerstore project, though it seems quite stale. If I don't hear anything about reviving that change, I'll probably start fresh (taking ideas/inspiration from that PR) tomorrow.

Edit: Tagging @csasarak!

@Stebalien
Copy link
Member

This exists now.

marten-seemann added a commit that referenced this issue Jan 17, 2022
marten-seemann pushed a commit that referenced this issue Apr 21, 2022
warn when we encounter a useless transport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue status/deferred Conscious decision to pause or backlog
Projects
None yet
Development

No branches or pull requests

7 participants