Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport + Swarm refactor #297

Closed
72 tasks done
Stebalien opened this issue Mar 8, 2018 · 4 comments
Closed
72 tasks done

Transport + Swarm refactor #297

Stebalien opened this issue Mar 8, 2018 · 4 comments

Comments

@Stebalien
Copy link
Member

Stebalien commented Mar 8, 2018

Moved from libp2p/go-libp2p-transport#21 for visibility.

Related to #279 (but this one is just about the refactor itself, not the overall task of QUIC + TLS + refactor).

State: In review. go-ipfs currently builds and runs (well) with these patches.

Branch feat/refactor in:

Branch master in the new repos:

Deprecated packages:

Known Issues:

  • Simultaneous dial problems are worse. This is caused by a combination of reuseport and TCP simultaneous open. The fact that it has gotten worse probably stems from a timing issue (lots of code cleanup so timing is probably more predictable).
  • We no longer treat half-closed streams as fully closed for the purposes of tracking them in the swarm. This means users must listen for the EOF on a stream after calling close. I've added two new functions to go-libp2p-net to help with this (FullClose and AwaitEOF).
Stebalien added a commit to libp2p/go-libp2p-net that referenced this issue Mar 9, 2018
Stebalien added a commit to libp2p/go-libp2p-net that referenced this issue Jun 5, 2018
Stebalien added a commit to libp2p/go-libp2p-net that referenced this issue Jun 5, 2018
@Stebalien
Copy link
Member Author

Done!

@dignifiedquire
Copy link
Member

🎉 congrats @Stebalien for slaying another 🐉

@ghost
Copy link

ghost commented Jun 20, 2018

All hail @Stebalien <3

@dirkmc
Copy link
Contributor

dirkmc commented Jun 29, 2018

Amazing 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants