Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example/echo docs improvement re securing identity #179

Closed
zippy opened this issue Feb 21, 2017 · 1 comment · Fixed by #223
Closed

example/echo docs improvement re securing identity #179

zippy opened this issue Feb 21, 2017 · 1 comment · Fixed by #223
Assignees
@Stebalien

Comments

@zippy
Copy link
Contributor

zippy commented Feb 21, 2017

When I follow the instructions in examples/echo/README I see warnings about identity (see below). It would be very useful for this to be documented, and then the additional steps needed to securing the connection be added in.

./echo -d /ip4/127.0.0.1/tcp/1235/ipfs/QmNtX1cvrm2K6mQmMEaMxAuB4rTexhd87vpYVot4sEZzxc -l 1236
12:40:57.969 WARNI swarm2: Listener not given PrivateKey, so WILL NOT SECURE conns. swarm_listen.go:83
2017/02/21 12:40:57 I am /ip4/127.0.0.1/tcp/1236/ipfs/QmVvtzcZgCkMnSFf2dnrBPXrWuNFWNM9J3MpZQCvWPuVZf
2017/02/21 12:40:57 opening stream
12:40:57.971 WARNI conn: dialer %s dialing INSECURELY %s at %s!<Dialer <peer.ID VvtzcZ> ...><peer.ID NtX1cv>/ip4/127.0.0.1/tcp/1235 dial.go:138
12:40:57.972 ERROR net/identi: did not have own public key in Peerstore id.go:177
2017/02/21 12:40:57 read reply: "Hello, world!"
@hsanjuan
Copy link
Contributor

You can call ./echo with -secio (as shown with -help) and then it will use randomly generated keys to encrypt the channel. Would you like to make a PR against the README telling about this in a way you would understand?

Stebalien added a commit that referenced this issue Aug 31, 2017
@Stebalien
examples/echo: recommend -secio
00cf69e 
When not using -secio, this command prints a warning. This confuses users so we
should just tell users to use it in the instructions.

fixes #179
@Stebalien Stebalien mentioned this issue Aug 31, 2017
Merged
@daviddias daviddias added the status/in-progress In progress label Aug 31, 2017
@daviddias daviddias removed the status/in-progress In progress label Sep 1, 2017
marten-seemann added a commit that referenced this issue Aug 9, 2022
@marten-seemann
chore: update go-log to v2 (#179)
3238e0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

examples/echo: recommend -secio libp2p/go-libp2p
4 participants
@zippy @Stebalien @hsanjuan @daviddias