identify: refactor sending of Identify pushes

libp2p · Jan 12, 2023 · f5fa030 · f5fa030
1 parent 6bcab9e
commit f5fa030
Show file tree

Hide file tree

Showing 9 changed files with 252 additions and 402 deletions.
diff --git a/p2p/host/basic/basic_host.go b/p2p/host/basic/basic_host.go
@@ -292,6 +292,8 @@ func NewHost(n network.Network, opts *HostOpts) (*BasicHost, error) {
 		ListenCloseF: listenHandler,
 	})
 
+	h.ids.Start()
+
 	return h, nil
 }
 

diff --git a/p2p/net/mock/mock_test.go b/p2p/net/mock/mock_test.go
@@ -528,7 +528,7 @@ func TestLimitedStreams(t *testing.T) {
 	}
 
 	wg.Wait()
-	if !within(time.Since(before), time.Second*2, time.Second) {
+	if !within(time.Since(before), time.Second*3, time.Second) {
 		t.Fatal("Expected 2ish seconds but got ", time.Since(before))
 	}
 }

diff --git a/p2p/protocol/holepunch/holepunch_test.go b/p2p/protocol/holepunch/holepunch_test.go
@@ -68,6 +68,8 @@ var _ identify.IDService = &mockIDService{}
 func newMockIDService(t *testing.T, h host.Host) identify.IDService {
 	ids, err := identify.NewIDService(h)
 	require.NoError(t, err)
+	ids.Start()
+	t.Cleanup(func() { ids.Close() })
 	return &mockIDService{IDService: ids}
 }