Don't use tracers here

libp2p · Jul 13, 2023 · 69bf883 · 69bf883
1 parent eb830c1
commit 69bf883
Showing 1 changed file with 8 additions and 13 deletions.
diff --git a/p2p/transport/quicreuse/connmgr.go b/p2p/transport/quicreuse/connmgr.go
@@ -50,23 +50,18 @@ func NewConnManager(statelessResetKey quic.StatelessResetKey, opts ...Option) (*
 
 	quicConf := quicConfig.Clone()
 
-	var tracers []quiclogging.Tracer
-
 	if cm.enableMetrics {
 		cm.mt = newMetricsTracer()
-		tracers = append(tracers, cm.mt)
 	}
-	if len(tracers) > 0 {
-		quicConf.Tracer = func(ctx context.Context, p quiclogging.Perspective, ci quic.ConnectionID) quiclogging.ConnectionTracer {
-			tracers := make([]quiclogging.ConnectionTracer, 0, 2)
-			if qlogTracerDir != "" {
-				tracers = append(tracers, qloggerForDir(qlogTracerDir, p, ci))
-			}
-			if cm.mt != nil {
-				tracers = append(tracers, cm.mt.TracerForConnection(ctx, p, ci))
-			}
-			return quiclogging.NewMultiplexedConnectionTracer(tracers...)
+	quicConf.Tracer = func(ctx context.Context, p quiclogging.Perspective, ci quic.ConnectionID) quiclogging.ConnectionTracer {
+		tracers := make([]quiclogging.ConnectionTracer, 0, 2)
+		if qlogTracerDir != "" {
+			tracers = append(tracers, qloggerForDir(qlogTracerDir, p, ci))
+		}
+		if cm.mt != nil {
+			tracers = append(tracers, cm.mt.TracerForConnection(ctx, p, ci))
 		}
+		return quiclogging.NewMultiplexedConnectionTracer(tracers...)
 	}
 	serverConfig := quicConf.Clone()
 	if !cm.enableDraft29 {