Skip to content

Commit

Permalink
quic: increase the buffer size used for encoding qlogs (#1715)
Browse files Browse the repository at this point in the history
  • Loading branch information
marten-seemann authored Aug 25, 2022
1 parent 173fb50 commit 423eab2
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions p2p/transport/quic/tracer.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ func newQlogger(qlogDir string, role logging.Perspective, connID []byte) io.Writ
return &qlogger{
f: f,
filename: finalFilename,
Writer: bufio.NewWriter(f),
// The size of a qlog file for a raw file download is ~2/3 of the amount of data transferred.
// bufio.NewWriter creates a buffer with a buffer of only 4 kB, leading to a large number of syscalls.
Writer: bufio.NewWriterSize(f, 128<<10),
}
}

Expand All @@ -76,7 +78,7 @@ func (l *qlogger) Close() error {
return err
}
defer f.Close()
buf := bufio.NewWriter(f)
buf := bufio.NewWriterSize(f, 128<<10)
c, err := zstd.NewWriter(buf, zstd.WithEncoderLevel(zstd.SpeedFastest), zstd.WithWindowSize(32*1024))
if err != nil {
return err
Expand Down

0 comments on commit 423eab2

Please sign in to comment.