Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom SubtestStress. #7

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Oct 29, 2019

SubtestStress is exposed but it was not possible to build a working opt parameters.
That was a problem for me when I was trying to discover muxing issue with the utp transport, see libp2p/go-utp-transport#5, part Need Help.

SubtestStress is exposed but it was not possible to build a working opt parameters.
@vyzo vyzo requested a review from raulk October 29, 2019 09:35
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making this parametrisable.

@raulk raulk merged commit 82713a6 into libp2p:master Oct 29, 2019
@raulk
Copy link
Member

raulk commented Oct 29, 2019

@Jorropo I cut a release (v0.1.1) with this change so you can import it downstream.

@Jorropo Jorropo deleted the feat/AllowCustomSubtestStress branch October 29, 2019 15:02
@Jorropo
Copy link
Contributor Author

Jorropo commented Oct 29, 2019

@raulk thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants