This repository has been archived by the owner on May 26, 2022. It is now read-only.
avoid spawning goroutines for canceled dials #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may speed up working through our dial queue a bit (bit probably isn't the main issue).
ghost
assigned 
raulk
approved these changes
Jan 23, 2019
|
|
||
| // Skip over canceled dials instead of queuing up a goroutine. | ||
| if next.cancelled() { | ||
| dl.freePeerToken(next) |
There was a problem hiding this comment.
Good catch, the peer token wasn't being freed in the case of a cancellation.
There was a problem hiding this comment.
I don't think that was the issue. We'd (a) spawn an executeDial goroutine and then (b) free the token when we returned from it. This PR just avoids spawning goroutines that we don't need.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may speed up working through our dial queue a bit (but probably isn't the main issue).