Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

slim down dependencies #225

Merged
merged 2 commits into from
Jun 24, 2020
Merged

slim down dependencies #225

merged 2 commits into from
Jun 24, 2020

Conversation

Stebalien
Copy link
Member

Remove secio, quic, and circuit transports from testing dependencies.

  • We temporarily added quic/circuit dependencies because a test needed them. But this is no longer the case.
  • We introduced the secio dependency before we had a fully featured "insecure" transport for testing.

Removes secio, quic, and circuit dependencies. We were using them for testing
but we don't actually need them.
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For SecIO, this should be fine, as adding a real secure channel does not change our code coverage. But for circuit, I was under the impression that the goal of that test was to verify that we allow the dial even if we are FD-limiter, because the circuit transport does not consume further FDs if we’re already connected to the relay?

@Stebalien
Copy link
Member Author

IsFdConsumingAddr is a pure function. This test added the QUIC and circuit transports because, when it was first written, IsFdConsumingAddr looked at the registered transports themselves. But that was changed before the PR adding IsFdConsumingAddr was merged.

@Stebalien
Copy link
Member Author

TL;DR: this doesn't affect code coverage.

@Stebalien Stebalien merged commit 58c167a into master Jun 24, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants