Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

improve dial errors #145

Merged
merged 3 commits into from
Nov 5, 2019
Merged

improve dial errors #145

merged 3 commits into from
Nov 5, 2019

Conversation

Stebalien
Copy link
Member

  1. Always return the caller's context error if relevant.
  2. Don't return "context canceled" when we're just shutting down.
  3. Don't claim that the context deadline has been exceeded when the dial timeout is canceled.
  4. Don't return a "context canceled" error when we're internally canceling the dial.

1. Always return the caller's context error if relevant.
2. Don't return "context canceled" when we're just shutting down.
3. Don't claim that the context deadline has been exceeded when the dial timeout
is canceled.
@Stebalien Stebalien requested a review from raulk November 4, 2019 20:10
@Stebalien Stebalien merged commit 4440884 into master Nov 5, 2019
@Stebalien Stebalien deleted the feat/improve-dial-error branch November 5, 2019 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants