This repository has been archived by the owner on May 26, 2022. It is now read-only.
implement a garbage-collector for unused reuse connections #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
suggested changes
Aug 7, 2019
marten-seemann
force-pushed
the
reuse-garbage-collect
branch
from
5fde971
to
a68dcbb
Compare
Stebalien
approved these changes
Aug 12, 2019
| func (c *reuseConn) IncreaseCount() { atomic.AddInt32(&c.refCount, 1) } | ||
| func (c *reuseConn) DecreaseCount() { atomic.AddInt32(&c.refCount, -1) } | ||
| func (c *reuseConn) GetCount() int { return int(atomic.LoadInt32(&c.refCount)) } | ||
| func (c *reuseConn) IncreaseCount() { |
There was a problem hiding this comment.
nit: should probably be private.
There was a problem hiding this comment.
I don't think it actually matters. We're never exporting a reuseConn from this package, so there's no way a user could call this function anyway.
There was a problem hiding this comment.
Hm. But can't the user type assert?
There was a problem hiding this comment.
Not really. What we're returning is (wrapped) QUIC connections, not UDP connections.
There was a problem hiding this comment.
Ah, fair enough. I still think private functions are clearer but, well, we're not consistent about that anyways.
| c.mutex.Unlock() | ||
| } | ||
|
|
||
| func (c *reuseConn) ShouldGarbageCollect(now time.Time) bool { |
| c.mutex.Unlock() | ||
| } | ||
|
|
||
| func (c *reuseConn) DecreaseCount() { |
marten-seemann
force-pushed
the
reuse-garbage-collect
branch
from
a68dcbb
to
a53ee68
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70.
This PR implements the sweeper as suggested in #63.
The sweeper runs every 30 seconds and removes connections that have been unused for more than 10 seconds. In order to not leak go routines, it stops itself once a
reusedoesn't have any more active connections, and is restarted as soon as a connection is added.