This repository has been archived by the owner on May 26, 2022. It is now read-only.
reuse the same router until we change listeners #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/cache-routes
branch
from
ae6a01f
to
4fd8b23
Compare
Technically, someone can set net.ipv4.ip_nonlocal_bind=1 to bind to non-existent IP addresses, but I'm comfortable making this change and seeing if anyone complains. I highly doubt it'll have any impact. If it doesn't work out, we have other options (e.g., catch the "invalid route" error and try again). fixes #238
Stebalien
force-pushed
the
feat/cache-routes
branch
from
4fd8b23
to
2a1fb10
Compare
marten-seemann
approved these changes
Nov 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, someone can set net.ipv4.ip_nonlocal_bind=1 to bind to non-existent IP addresses, but I'm comfortable making this change and seeing if anyone complains. I highly doubt it'll have any impact.
If it doesn't work out, we have other options (e.g., catch the "invalid route" error and try again).