Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

reject /dns addresses when dialing #126

Closed
wants to merge 2 commits into from
Closed

reject /dns addresses when dialing #126

wants to merge 2 commits into from

Conversation

marten-seemann
Copy link
Collaborator

Fixes #123.

@Stebalien
Copy link
Member

Let's wait until we resolve the go-libp2p bug.

Really, this shouldn't be unnecessary, strictly speaking because, CanDial should return false when passed a dns addr. However, it currently returns true because this now includes dns, and QUIC is defined here.

@marten-seemann
Copy link
Collaborator Author

CanDial is implemented by the QUIC transport. We can add the check there as well.

@marten-seemann
Copy link
Collaborator Author

@Stebalien I just fixed the behavior of CanDial to return false for /dns addresses.

raulk
raulk suggested changes Mar 16, 2020
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right solution. See #123 (comment).

@Stebalien Stebalien closed this Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raulk raulk raulk requested changes

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RemoteMultiaddr should be fully resolved
3 participants
@marten-seemann @Stebalien @raulk