Update peer-exchange branch with PeerRecord api changes #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
vyzo
reviewed
Jan 23, 2020
gossipsub.go
Outdated
| @@ -3,6 +3,7 @@ package pubsub | |||
| import ( | |||
| "context" | |||
| "fmt" | |||
| "github.com/libp2p/go-libp2p-core/record" | |||
There was a problem hiding this comment.
can you put this together with our other imports? Here it is mixed with system imports.
gossipsub.go
Outdated
| @@ -820,21 +828,24 @@ func (gs *GossipSubRouter) makePrune(p peer.ID, topic string) *pb.ControlPrune { | |||
| return p != xp | |||
| }) | |||
|
|
|||
| cab, peerstoreSupportsSignedAddrs := peerstore.GetCertifiedAddrBook(gs.p.host.Peerstore()) | |||
There was a problem hiding this comment.
can we call the variable something shorter? This is an eyesore.
vyzo
reviewed
Jan 23, 2020
gossipsub.go
Outdated
Comment on lines
315
to
319
| rec, ok := r.(*peer.PeerRecord) | ||
| if !ok { | ||
| log.Warnf("bogus routing record obtained through px: envelope payload is not PeerRecord") | ||
| } | ||
| if rec.PeerID != p { |
There was a problem hiding this comment.
there is a control flow issue here; if !ok then rec.PeerID is a nil pointer dereference, which could crash.
There was a problem hiding this comment.
thanks for catching that 👍
vyzo
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @vyzo, this PR is based on the branch for #234 and just updates it to work with the various name changes that have happened to the signed peer records PR (libp2p/go-libp2p-core#73).
let me know if you have any questions & also feel free to comment on the -core PR if you think we need to change the API at all before merge.