Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PubSub's context to Subscription #201

Merged
merged 1 commit into from
Oct 1, 2019
Merged

add PubSub's context to Subscription #201

merged 1 commit into from
Oct 1, 2019

Conversation

lukesolo
Copy link

Fix for #200

This patch fixes the issue, but what about functions which get outer context as an argument, e.g. Next(ctx context.Context). Should these functions check only outer context for cancellation or inner too?

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vyzo vyzo merged commit dba8299 into libp2p:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants