fix: ignore bad peers when fetching the latest value #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Feb 5, 2020
|
We're seeing a lot of errors on the gateway when ipns pubsub peers connect without supporting this fetch protocol. |
aschmahmann
requested changes
Feb 5, 2020
There was a problem hiding this comment.
@Stebalien thanks for taking a look at this. Seems fine by me, although as I mention in my comment we should either change or remove the code for tracking peers that we fail to Fetch from.
Stebalien
force-pushed
the
fix/ignore-bad-peers
branch
from
38e56b0
to
1a38051
Compare
They may not support the protocol. Or they may just not give us what we're looking for. We might as well keep asking till someone answers.
Stebalien
force-pushed
the
fix/ignore-bad-peers
branch
from
1a38051
to
6a6dbc4
Compare
aschmahmann
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They may not support the protocol. Or they may just not give us what we're looking for. We might as well keep asking till someone answers.