Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

improve interning #79

Merged
merged 2 commits into from
May 28, 2019
Merged

improve interning #79

merged 2 commits into from
May 28, 2019

Conversation

Stebalien
Copy link
Member

  1. Remove intern limits on protocols. Those only existed because the logic applied to all datastores. As the in-memory datastore doesn't have any form of GC, there's no need to limit interning in any way.
  2. Intern specific metadata. The AgentVersion and ProtocolVersion are, in fact, using up quite a bit of memory in long-running machines.

@Stebalien
feat: improve protocol interning
fd3ea88 
This used to specify a max size/count but that was only because this logic was
shared between all peerstores (including the on-disk one). Now that:

1. This only applies to the in-memory one.
2. We never actually GC these.

We can just intern indefinitely.
@Stebalien
feat: intern agent versions
d2e2c56 
This also starts taking up a bunch of memory after a while.
@Stebalien Stebalien merged commit aeb6adb into master May 28, 2019
@Stebalien Stebalien deleted the feat/better-intern branch May 28, 2019 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @vyzo