Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: linting fixes #578

Merged
merged 6 commits into from
Apr 9, 2020
Merged

chore: linting fixes #578

merged 6 commits into from
Apr 9, 2020

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Apr 9, 2020

Here's some fixes for linter warnings so my editor doesn't appear so yellow.

⚠️ there's a change to an error message - I don't know if this is considered breaking in golang.

There's also a bunch of linter warnings in dht_test.go for passing ctx as the first parameter, but I also read somewhere that t should be passed first (as it is) so I don't know who's most correct.

Screenshot 2020-04-09 at 10 55 40

P.S. may I have write perms?

@Stebalien Stebalien merged commit 969e03e into libp2p:master Apr 9, 2020
@alanshaw alanshaw deleted the chore/linting-fixes branch April 15, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants