Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove local provider check #577

Merged
merged 1 commit into from
Apr 9, 2020
Merged

fix: remove local provider check #577

merged 1 commit into from
Apr 9, 2020

Conversation

Stebalien
Copy link
Member

It doesn't actually work. Blocks are stored under /blocks and have been since 2015.

Furthermore, this is just wrong. We shouldn't go digging through the datastore to see if we happen to have the block. If we want something like this, we should include a blockstore in the provider manager.

It doesn't actually work. Blocks are stored under /blocks and have been since
2015.

Furthermore, this is just wrong. We shouldn't go digging through the datastore
to see if we happen to have the block. If we want something like this, we should
include a blockstore in the provider manager.
@Stebalien Stebalien requested a review from willscott April 9, 2020 01:27
@Stebalien Stebalien merged commit 0d1a917 into master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants