fix: use the routing table filter #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should get some tests. I hate to do this, but could you write them @willscott? |
willscott
requested changes
Apr 8, 2020
dht_filters.go
Outdated
| expires := routerCache.expires | ||
| routerCache.RUnlock() | ||
|
|
||
| if router != nil && time.Now().After(expires) { |
Stebalien
force-pushed
the
feat/filter-rt
branch
from
23afcb5
to
3e785dd
Compare
Unfortunately, constructing a router is _not_ cheap. Cache it so we don't have to re-compute it every time we get a query.
Stebalien
force-pushed
the
feat/filter-rt
branch
from
3e785dd
to
9461bab
Compare
|
fix #575 |
willscott
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
@Stebalien you should also confirm tests look okay. i don't think you can 'approve' since you opened the PR though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, cache routing info so we don't need to repeatedly recompute it.
We should also consider caching known-filtered peers... but we can do that after
profiling.