RT peer validation should also include support for the DHT protocol #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Mar 19, 2020
| func makeRoutingTable(h host.Host, cfg config) (*kb.RoutingTable, error) { | ||
| self := kb.ConvertPeerID(h.ID()) | ||
| func makeRoutingTable(dht *IpfsDHT, cfg config) (*kb.RoutingTable, error) { | ||
| self := kb.ConvertPeerID(dht.host.ID()) | ||
| // construct the routing table with a peer validation function | ||
| pvF := func(c context.Context, p peer.ID) bool { |
There was a problem hiding this comment.
this change looks fine to me.
At some point, we should declare the pvF as a normal method of the DHT, rather than creating it as an anonymous function in makeRoutingTable, which ought to simplify some of these references.
|
@aschmahmann Merging this. Lmk if you have issues & I can address them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Stebalien @aschmahmann
RT PR at libp2p/go-libp2p-kbucket#59