Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce memory used by buffered writers #332

Merged
merged 1 commit into from
May 8, 2019

Conversation

Stebalien
Copy link
Member

Allocate them as-needed and use a pool.

Work towards #322.

@ghost ghost assigned Stebalien May 8, 2019
@ghost ghost added the status/in-progress In progress label May 8, 2019
Allocate them as-needed and use a pool.

Work towards #322.
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The default bufio length is 4096 – this might be overallocating for the purposes of DHT messaging, not sure. But with the pool in place now, I expect tuning the size will have little impact anyway.

@Stebalien Stebalien merged commit 1449871 into master May 8, 2019
@Stebalien Stebalien deleted the fix/reduce-buffer-memory branch May 8, 2019 18:11
@ghost ghost removed the status/in-progress In progress label May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants