fix(providers): gc #325
Merged
fix(providers): gc #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we'll delete everything.
ghost
assigned 
vyzo
reviewed
Apr 19, 2019
| @@ -31,7 +31,7 @@ type ProviderManager struct { | |||
| // all non channel fields are meant to be accessed only within | |||
| // the run method | |||
| providers *lru.LRU | |||
| dstore ds.Datastore | |||
| dstore *autobatch.Datastore | |||
There was a problem hiding this comment.
are we concerned about the lack of thread-safety in the autobatching datastore?
There was a problem hiding this comment.
We're only using it from one thread here.
| @@ -193,8 +193,7 @@ func writeProviderEntry(dstore ds.Datastore, k cid.Cid, p peer.ID, t time.Time) | |||
|
|
|||
| func (pm *ProviderManager) gc() { | |||
| res, err := pm.dstore.Query(dsq.Query{ | |||
| KeysOnly: true, | |||
There was a problem hiding this comment.
ok, that's a subtle little change. What's the difference here?
There was a problem hiding this comment.
The expiration is in the value. We had this before because we'd:
- Determine that all records have expired.
- Delete all records.
This caused us to remember a bunch of expired records indefinitely.
vyzo
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we'll delete everything.