Rephrase "betterPeersToQuery" method comment to be less cryptic #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
requested changes
Nov 15, 2018
dht.go
Outdated
| @@ -330,7 +330,7 @@ func (dht *IpfsDHT) nearestPeersToQuery(pmes *pb.Message, count int) []peer.ID { | |||
| return closer | |||
| } | |||
|
|
|||
| // betterPeerToQuery returns nearestPeersToQuery, but iff closer than self. | |||
| // betterPeersToQuery returns nearestPeersToQuery, but if closer than self. | |||
There was a problem hiding this comment.
iff is not a typo, it means if and only if; please leave it there.
There was a problem hiding this comment.
or expand if it seems too cryptic.
|
Hi @vyzo , I adjusted the PR. |
mtojek
changed the title
vyzo
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.