buffer writes when sending protobufs #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
The protobuf writer performs multiple small writes when writing a message. We need to buffer these, otherwise we'll send out a packet for each Write call.
marten-seemann
force-pushed
the
buffer-writes
branch
from
0864ae2
to
6d6ed07
Compare
|
also cc @bigs, dht perf :) |
bigs
approved these changes
Aug 6, 2018
Stebalien
approved these changes
Aug 6, 2018
|
Great find 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Protobuf writer performs multiple small writes when writing a message. We need to buffer these, otherwise we'll send out a packet for each Write call.
This will reduce the number of packets sent when providing records by 75%.
Verified that it works by looking at the QUIC packet log. Every DHT record is now sent in a single packet.