Skip to content

Commit

Permalink
Merge pull request #455 from libp2p/fix/warn-to-error
Browse files Browse the repository at this point in the history
fix(providers): upgrade warnings to errors
  • Loading branch information
Stebalien authored Feb 21, 2020
2 parents 5552b3f + 9f0782b commit de00be3
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions providers/providers.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,13 @@ func loadProvSet(dstore ds.Datastore, k []byte) (*providerSet, error) {
switch {
case err != nil:
// couldn't parse the time
log.Warning("parsing providers record from disk: ", err)
log.Error("parsing providers record from disk: ", err)
fallthrough
case now.Sub(t) > ProvideValidity:
// or just expired
err = dstore.Delete(ds.RawKey(e.Key))
if err != nil && err != ds.ErrNotFound {
log.Warning("failed to remove provider record from disk: ", err)
log.Error("failed to remove provider record from disk: ", err)
}
continue
}
Expand All @@ -151,7 +151,7 @@ func loadProvSet(dstore ds.Datastore, k []byte) (*providerSet, error) {
log.Error("base32 decoding error: ", err)
err = dstore.Delete(ds.RawKey(e.Key))
if err != nil && err != ds.ErrNotFound {
log.Warning("failed to remove provider record from disk: ", err)
log.Error("failed to remove provider record from disk: ", err)
}
continue
}
Expand Down Expand Up @@ -264,13 +264,13 @@ func (pm *ProviderManager) run(proc goprocess.Process) {
switch {
case err != nil:
// couldn't parse the time
log.Warning("parsing providers record from disk: ", err)
log.Error("parsing providers record from disk: ", err)
fallthrough
case gcTime.Sub(t) > ProvideValidity:
// or expired
err = pm.dstore.Delete(ds.RawKey(res.Key))
if err != nil && err != ds.ErrNotFound {
log.Warning("failed to remove provider record from disk: ", err)
log.Error("failed to remove provider record from disk: ", err)
}
}

Expand Down

0 comments on commit de00be3

Please sign in to comment.