Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

correctly encode ns to CID #11

Merged
merged 1 commit into from
Feb 14, 2019
Merged

correctly encode ns to CID #11

merged 1 commit into from
Feb 14, 2019

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Feb 14, 2019

Closes #10.

@ghost ghost assigned vyzo Feb 14, 2019
@ghost ghost added the status/in-progress In progress label Feb 14, 2019
@vyzo vyzo requested a review from raulk February 14, 2019 10:53
@vyzo vyzo mentioned this pull request Feb 14, 2019
Closed
raulk
raulk approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add some test vectors in a unit test to prevent regressions here.

@vyzo
Copy link
Contributor Author

vyzo commented Feb 14, 2019

Sure, but let's do that in a subsequent pr.

@vyzo vyzo merged commit 17aa7d7 into master Feb 14, 2019
@ghost ghost removed the status/in-progress In progress label Feb 14, 2019
@vyzo vyzo deleted the fix/issue-10 branch February 14, 2019 10:59
@raulk raulk mentioned this pull request Feb 20, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raulk raulk raulk approved these changes

Assignees

@vyzo vyzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyzo @raulk