Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Commit

Permalink
Revert "return buffer to pool before early return"
Browse files Browse the repository at this point in the history
8d8da38

misread this - unsigned will be nil if there's an
error, so it was right the way it was
  • Loading branch information
yusefnapora committed Jan 17, 2020
1 parent 7ee4611 commit 3c208b0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions record/envelope.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ func MakeEnvelope(privateKey crypto.PrivKey, domain string, payloadType []byte,

seq := statelessSeqNo()
unsigned, err := makeUnsigned(domain, payloadType, payload, seq)
defer pool.Put(unsigned)
if err != nil {
return nil, err
}
defer pool.Put(unsigned)

sig, err := privateKey.Sign(unsigned)
if err != nil {
Expand Down Expand Up @@ -226,10 +226,10 @@ func (e *Envelope) TypedRecord(dest Record) error {
// or an error if signature validation fails.
func (e *Envelope) validate(domain string) error {
unsigned, err := makeUnsigned(domain, e.PayloadType, e.RawPayload, e.Seq)
defer pool.Put(unsigned)
if err != nil {
return err
}
defer pool.Put(unsigned)

valid, err := e.PublicKey.Verify(unsigned, e.signature)
if err != nil {
Expand Down

0 comments on commit 3c208b0

Please sign in to comment.