This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Tag the hop relay when creating stop streams #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
previously requested changes
May 22, 2019
|
@vyzo I changed the target branch of this PR to the correct one. |
|
I was planning to merge it on master separately because it solves a different issue, we'll have to change the target branch back again. We can also do this after we merge #76, as it makes it easier to review. |
raulk
suggested changes
May 22, 2019
raulk
approved these changes
May 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tags the underlying hop relay with the connection manager when we open a new stop stream.
This should avoid the comical situation of dropping the hop relay connection and killing all the relayed connections with it in the connection manager.
On top of #76