This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Tag peers with live hop streams #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
approved these changes
May 7, 2019
There was a problem hiding this comment.
This works, but we may want to consider reusing the existing goroutines. That is, either:
- Have one goroutine wait for the other to finish and make it responsible for cleaning up.
- Have both goroutines check/set an atomic counter. When the counter reaches 0, that goroutine does the cleanup.
usually, I'd say to just stick with an extra goroutine. However, we have a lot of goroutines here.
|
But I do like the idea of the atomic counter, it's more code but totally obviates the need for the extra goroutine. |
|
Alright, implemented with an atomic counter. |
vyzo
commented
May 7, 2019
| @@ -364,10 +369,18 @@ func (r *Relay) handleHopStream(s inet.Stream, msg *pb.CircuitRelay) { | |||
|
|
|||
| r.addLiveHop(src.ID, dst.ID) | |||
|
|
|||
| goroutines := new(int32) | |||
There was a problem hiding this comment.
note that this is allocated on the heap to avoid lingering the original goroutine stack.
Stebalien
approved these changes
May 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds connection manager tagging for peers with live hops.
Note the extra supervisory goroutine in the hop, as we need to ensure both sides are closed before removing the tag and reduce the live hop count.
Closes #65