This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
feat: remove relay discovery and unspecified relay dialing #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a misfeature that looks great in demos but isn't useful in practice. First, random relays we discover are unlikely to support _active_ relaying. This means that picking a random relay is usually going to fail because the random relay won't already be connected to the target. Second, there are two use-cases for relaying: 1. Connecting to undialable nodes. 2. Relaying all outbound traffic. For the first case, we only want to use the relays specified by the target peers. For the second case, we'd need to modify either libp2p's dialer logic (in the swarm) to prefix all addresses with the specified relay. The logic _here_ covers neither use-case.
Introduce functional options. This should make it easier for us to add additional options in the future (e.g., known relays, relay policies, etc.).
vyzo
reviewed
Mar 31, 2020
|
Why? |
|
It is useful for driving relay discovery (say for autorelay); couple that with a relay filters, and we can have a very simple mechanism for setting up relay forwarding. |
|
We don't use this for AutoRelay, we don't even expose the relays we find. AutoRelay now discovers its own relays via identify events. |
|
(sorry, I just like deleting code) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a misfeature that looks great in demos but isn't useful (and wastes bandwidth and could potentially cause other DoS issues) in practice.
First, random relays we discover are unlikely to support active relaying. This means that picking a random relay is usually going to fail because the random relay won't already be connected to the target.
Second, there are two use-cases for relaying:
For the first case, we only want to use the relays specified by the target peers. For the second case, we'd need to modify either libp2p's dialer logic (in the swarm) to prefix all addresses with the specified relay.
The current logic covers neither use-case so I'm removing it.