This repository has been archived by the owner on May 11, 2022. It is now read-only.
change autonat interface to use functional options #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Mar 16, 2020
| return nil | ||
| } | ||
|
|
||
| // WithAddresses allows overriding which Addresses the AutoNAT client beliieves |
There was a problem hiding this comment.
Suggested change
| // WithAddresses allows overriding which Addresses the AutoNAT client beliieves | |
| // WithAddresses allows overriding which Addresses the AutoNAT client believes |
| // are "its own". Useful for testing, or for more exotic port-forwarding | ||
| // scenarios where the host may be listening on different ports than it wants | ||
| // to externally advertise or verify connectability on. | ||
| func WithAddresses(addrFunc GetAddrs) Option { |
There was a problem hiding this comment.
Maybe call this AddressGuesser? As far as I can tell, that's really what this is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #43