Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PeerStore content & TEMP generalize PeerID guide #193

Merged
merged 6 commits into from
Sep 23, 2022
Merged

Conversation

salmad3
Copy link
Member

@salmad3 salmad3 commented Sep 19, 2022

Context

Latest preview

Please view the latest Fleek preview here.

@salmad3 salmad3 added the ready for review PR is ready for review label Sep 19, 2022
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
@salmad3
Copy link
Member Author

salmad3 commented Sep 21, 2022

Thanks @marten-seemann! Added changes

content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
content/concepts/peers.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably do a sed s/Peer Id/Peer ID/g over this document before merging. @DannyS03 feel free to merge the PR once you done that without another round of review.

@salmad3 salmad3 removed the ready for review PR is ready for review label Sep 23, 2022
@salmad3 salmad3 merged commit 64081ce into master Sep 23, 2022
@salmad3 salmad3 deleted the peerstore branch January 3, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants