Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create assertion error records #62

Open
oubiwann opened this issue Aug 15, 2020 · 2 comments
Open

Create assertion error records #62

oubiwann opened this issue Aug 15, 2020 · 2 comments
Milestone

Comments

@oubiwann
Copy link
Member

There are places in ltest that have to do some very ugly destructuring:

This is due to Erlang having some pretty ugly (also probably quite old) error-creation for assertions, e.g.:

Let's create some records (just the ones that are necessary) to at least keep our code clean.

These are going to need LOTS OF TESTS.

@oubiwann oubiwann added this to the 0.11.0 milestone Aug 15, 2020
@oubiwann
Copy link
Member Author

This will show other similar ugly spots: git grep ',_ ,_' (all in the listener code).

Two of these are errors.

One is an ok.

Four are descriptions of ebins / modules.

One is test data.

These could all use some records ...

@oubiwann
Copy link
Member Author

I'm not 100% convinced about the usefulness of this, really ...

In theory, sounds great, but in practice, I'm not sure it would be used much. Maybe in one or two places with little impact?

@oubiwann oubiwann modified the milestones: 0.11.0, 1.0.0 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant