Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish artifacts #16

Open
erip opened this issue Jan 14, 2021 · 6 comments · Fixed by #18
Open

Publish artifacts #16

erip opened this issue Jan 14, 2021 · 6 comments · Fixed by #18

Comments

@erip
Copy link
Contributor

erip commented Jan 14, 2021

With the newly merged work in #12 and #14, it's possible to publish cross-platform artifacts to Maven central or even GitHub Packages for broad consumption. I think there may be a few other things to consider before doing this (e.g., should the sentencepiece version == package version? should it be a classifier?), but this issue tracks that.

@levyfan
Copy link
Owner

levyfan commented Jan 15, 2021

And for linux, it is better to use an old version linux distribution to avoid glibc issues, for example, centos6 for manylinux2010 in https://github.com/pypa/manylinux. (Compiling on high version glibc can not run on lower version glibc linux)

@levyfan levyfan linked a pull request Jan 19, 2021 that will close this issue
@erip
Copy link
Contributor Author

erip commented Jan 25, 2021

@levyfan would you be willing to cut a 0.0.2 release? If so I can submit another PR for 0.0.3-SNAPSHOT.

@levyfan levyfan reopened this Jan 26, 2021
@levyfan
Copy link
Owner

levyfan commented Jan 26, 2021

@erip The release fails to upload multiple sentencepiece-0.0.2.pom to same place.

Error: Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on project sentencepiece: Failed to deploy artifacts: Could not transfer artifact com.github.levyfan:sentencepiece:pom:0.0.2 from/to github (https://maven.pkg.github.com/levyfan/sentencepiece-jni): Transfer failed for https://maven.pkg.github.com/levyfan/sentencepiece-jni/com/github/levyfan/sentencepiece/0.0.2/sentencepiece-0.0.2.pom 409 Conflict -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error: Process completed with exit code 1.

@levyfan
Copy link
Owner

levyfan commented Jan 26, 2021

@erip
Copy link
Contributor Author

erip commented Jan 26, 2021

It seems like the classifier isn't being added to the pom name. I'd expect separate poms for the separate platforms. Let me dig into.it.

@Lundez
Copy link

Lundez commented Dec 11, 2021

@erip any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants